Raise default compile timeout to 60s and improve timeout error message#2192
Conversation
kolina
left a comment
There was a problem hiding this comment.
LGTM, but can you please remove non-related changes for other fix?
The branch with this fix comes out of the branch fix_issue_2177 for the other fix. This branch contains just the commit related to this issue. Those are chained changes (wanted to avoid merge conflicts while having independent branches and to save PR round trips). Unfortunately GitHub by default shows diffs from this and the other branches at the same time. Those could be filtered out in GitHub UI. |
Default compilation timeout was 30s. Bump to 60s so larger projects don't hit it on a single compile pass. Extends the "Compilation timed out" error to point at --timeout with concrete examples (--timeout=2m, --timeout=1h) so users can self-mitigate without reading docs.
09eab61 to
8529cc1
Compare
After the source branch has been merged and rebase now GitHub shows just clean contents of this commit. |
Default compilation timeout was 30s. Bump to 60s so larger projects don't hit it on a single compile pass.
Extends the "Compilation timed out" error to point at --timeout with concrete examples (--timeout=2m, --timeout=1h) so users can self-mitigate without reading docs.