Switch registry at CI builds explicitly#2075
Merged
ikholopov-omni merged 1 commit intodataform-co:mainfrom Jan 29, 2026
Merged
Conversation
b0323c0 to
0cf30b1
Compare
0cf30b1 to
a23f209
Compare
kolina
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dataform uses trusted registry for CI builds. It does that by relying on nodejs's
npm installinteraction with yarn.lock. This interaction is known to be error-prone (for ex. npm/cli#5126), yarn recommends to only use yarn CLI when working with it's ecosystem. In particular, it blocks update of the Node, forcing us to use the version that is long out of EOL support (v16). Newer version breaks yarn.lock onnpm install. Apart from that we don't verify that yarn.lock updates only registry.Addressing that by reimplementing registry substitution explicitly and switching to
yarn install --freeze-lockfileinstead ofnpm install. This will ensure that:Long-term solution would be migration to a supported NodeJS rules (most likely Aspect's), where we would be able to leverage PNPM, whose lockfile doesn't fix registry URL at all - only versions and hashsums.