Conversation
fernst
reviewed
Nov 13, 2025
cli/index.ts
Outdated
| }; | ||
|
|
||
| const bigqueryLabelsOption: INamedOption<yargs.Options> = { | ||
| name: "bigquery-labels", |
Collaborator
There was a problem hiding this comment.
Should this be job-labels? In BQ, jobs can be both in the job and in the table itself.
Contributor
Author
There was a problem hiding this comment.
Good point, updated to use job-labels
kolina
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add support for bq job labelling when in
dataform runcommand. This provides user more flexibility of correlating created jobs with custom global level labels