Fix Correct typo in kpop.boy_bands key in ko.yml#1635
Fix Correct typo in kpop.boy_bands key in ko.yml#1635asolntsev merged 2 commits intodatafaker-net:mainfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1635 +/- ##
============================================
- Coverage 92.41% 92.36% -0.05%
+ Complexity 3383 3381 -2
============================================
Files 333 333
Lines 6670 6670
Branches 664 664
============================================
- Hits 6164 6161 -3
- Misses 348 349 +1
- Partials 158 160 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think that data in ko is unused. https://github.com/search?q=repo%3Adatafaker-net%2Fdatafaker%20boy_ban&type=code @asolntsev @snuyanzin @bodiam is there a handy way we can identify such cases, either as standalone code and doing a clean-up pass or in unit tests? |
@RepeatedTest(10)
void testKpopDataInKoreanLocale() {
Faker faker = new Faker(Locale.KOREA);
faker.kpop().iGroups(); // ko.yml
faker.kpop().iiGroups(); // ko.yml
faker.kpop().iiiGroups(); // ko.yml
faker.kpop().solo(); // ko.yml
faker.kpop().boyBands(); // kpop.yml
}In the provided test method, the |
|
@Chanwon-Seo thanks! Maybe kpop isn't the perfect example for this: But I guess arguably someone may want kpop bands (or whatever) for a specific locale, vs a global or generic sampling. |
Corrects a typo in ko.yml from boy_bans to boy_bands to match the key used by the Kpop provider.
datafaker/src/main/resources/ko.yml
Line 97 in 565ab92