Skip to content

Fix Correct typo in kpop.boy_bands key in ko.yml#1635

Merged
asolntsev merged 2 commits intodatafaker-net:mainfrom
Chanwon-Seo:fix/ko-yml-key-typo
Sep 4, 2025
Merged

Fix Correct typo in kpop.boy_bands key in ko.yml#1635
asolntsev merged 2 commits intodatafaker-net:mainfrom
Chanwon-Seo:fix/ko-yml-key-typo

Conversation

@Chanwon-Seo
Copy link
Contributor

Corrects a typo in ko.yml from boy_bans to boy_bands to match the key used by the Kpop provider.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.36%. Comparing base (565ab92) to head (5ef8f52).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1635      +/-   ##
============================================
- Coverage     92.41%   92.36%   -0.05%     
+ Complexity     3383     3381       -2     
============================================
  Files           333      333              
  Lines          6670     6670              
  Branches        664      664              
============================================
- Hits           6164     6161       -3     
- Misses          348      349       +1     
- Partials        158      160       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kingthorin
Copy link
Collaborator

I think that data in ko is unused.

https://github.com/search?q=repo%3Adatafaker-net%2Fdatafaker%20boy_ban&type=code

@asolntsev @snuyanzin @bodiam is there a handy way we can identify such cases, either as standalone code and doing a clean-up pass or in unit tests?

@Chanwon-Seo
Copy link
Contributor Author

@RepeatedTest(10)
    void testKpopDataInKoreanLocale() {
        Faker faker = new Faker(Locale.KOREA);
        faker.kpop().iGroups(); // ko.yml
        faker.kpop().iiGroups(); // ko.yml
        faker.kpop().iiiGroups(); // ko.yml
        faker.kpop().solo(); // ko.yml
        faker.kpop().boyBands(); // kpop.yml
    }

In the provided test method, the iGroups(), iiGroups(), iiiGroups() and solo() methods correctly retrieve data from ko.yml.
However, it was observed that previously, due to a typo (boy_bans instead of boy_bands) in ko.yml, the boyBands() method was inadvertently fetching data from en/kpop.yml. This discrepancy highlighted an inconsistency in data sourcing for the Korean locale.

@kingthorin
Copy link
Collaborator

@Chanwon-Seo thanks!

Maybe kpop isn't the perfect example for this: But I guess arguably someone may want kpop bands (or whatever) for a specific locale, vs a global or generic sampling.

@asolntsev asolntsev added the bug Something isn't working label Sep 4, 2025
@asolntsev asolntsev added this to the 2.4.5 milestone Sep 4, 2025
@asolntsev asolntsev merged commit d01cec0 into datafaker-net:main Sep 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants