Support packed repeated fields#30
Merged
bluele merged 18 commits intodatachainlab:masterfrom Jan 14, 2022
Merged
Conversation
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
…ted fields can't be packed... Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
…mption) code Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
…ionally Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
…4} and generation to ProtoBufRuntime and fix the generator to generate estimate_packed_repeated_{enum_name} for each enum
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
5d77228 to
346786b
Compare
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
…eated Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
bluele
reviewed
Jan 6, 2022
| #!/usr/bin/env bash | ||
| set -e | ||
| for file in proto/* | ||
| rootdir="$(dirname "$0")" |
Member
There was a problem hiding this comment.
I think don't need to remove the shebang.
Contributor
Author
There was a problem hiding this comment.
Thanks. I removed them by mistake...
Signed-off-by: Masanori Yoshida <masanori.yoshida@datachain.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #23 by:
[packed=...]options[packed=...]options