This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Use defined timezone on write for formats that need TZ info#665
Merged
srowen merged 2 commits intodatabricks:masterfrom Oct 10, 2023
Merged
Use defined timezone on write for formats that need TZ info#665srowen merged 2 commits intodatabricks:masterfrom
srowen merged 2 commits intodatabricks:masterfrom
Conversation
HyukjinKwon
approved these changes
Oct 10, 2023
srowen
commented
Oct 10, 2023
| case (TimestampType, v: Timestamp) => | ||
| val formatter = options.timestampFormat.map(DateTimeFormatter.ofPattern). | ||
| getOrElse(DateTimeFormatter.ISO_INSTANT) | ||
| getOrElse(DateTimeFormatter.ISO_INSTANT). |
Collaborator
Author
There was a problem hiding this comment.
FWIW, I don't think this affects the port of spark-xml to Apache Spark. That code was modified to use Spark's more standard timestamp formatter code that always has a timezone available, it seems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #663