This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Closed
Conversation
srowen
suggested changes
Dec 22, 2022
| parameters.getOrElse("wildcardColName", XmlOptions.DEFAULT_WILDCARD_COL_NAME) | ||
| val ignoreNamespace = parameters.get("ignoreNamespace").map(_.toBoolean).getOrElse(false) | ||
| val timestampFormat = parameters.get("timestampFormat") | ||
| val timeZone = parameters.getOrElse("timeZone", XmlOptions.DEFAULT_TIME_ZONE) |
Collaborator
There was a problem hiding this comment.
Instead of exposing an option, use the value of Spark conf spark.sql.session.timeZone below. We would need to document this behavior in the README
| try { | ||
| return Timestamp.from(ZonedDateTime.parse(value, format).toInstant) | ||
| return Timestamp.from( | ||
| ZonedDateTime.parse(value, format.withZone(ZoneId.of(timeZone))).toInstant |
Collaborator
There was a problem hiding this comment.
The new logic should only be applied to the custom timestamp format, not the built-in ones.
I suppose, if possible, you check to see if the pattern has a TZ and augment it with the TZ specified in spark.sql.session.timeZone if not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#612