Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

Add 'declaration' option to control generation of XML declaration in output#560

Merged
srowen merged 4 commits intodatabricks:masterfrom
srowen:Declaration
Oct 7, 2021
Merged

Add 'declaration' option to control generation of XML declaration in output#560
srowen merged 4 commits intodatabricks:masterfrom
srowen:Declaration

Conversation

@srowen
Copy link
Copy Markdown
Collaborator

@srowen srowen commented Sep 29, 2021

This adds a new option, declaration, which controls the contents of an XML declaration at the very start of each output XML document, like <?xml ... ?>. Defaults to generating <?xml version="1.0" encoding="UTF-8" standalone="yes"?> but can be disabled by setting the option to null or empty string.

…ion, and default to generating a standard one.
…ion, and default to generating a standard one.
@srowen srowen self-assigned this Sep 29, 2021
@srowen srowen changed the title Add 'dec'aratopm Add 'declaration' option to control generation of XML declaration in output Sep 29, 2021
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #560 (2754da8) into master (80f8737) will increase coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
+ Coverage   85.49%   85.50%   +0.01%     
==========================================
  Files          18       18              
  Lines         965      973       +8     
  Branches       92       85       -7     
==========================================
+ Hits          825      832       +7     
- Misses        140      141       +1     
Impacted Files Coverage Δ
...in/scala/com/databricks/spark/xml/XmlOptions.scala 97.61% <75.00%> (-2.39%) ⬇️
.../scala/com/databricks/spark/xml/util/XmlFile.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f8737...2754da8. Read the comment docs.

@srowen srowen added this to the 0.14.0 milestone Oct 7, 2021
@srowen srowen merged commit 1e35b4f into databricks:master Oct 7, 2021
@srowen srowen deleted the Declaration branch October 7, 2021 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants