This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Return null for primitive types when value matches nullValue string#542
Merged
srowen merged 2 commits intodatabricks:masterfrom Jun 10, 2021
Merged
Return null for primitive types when value matches nullValue string#542srowen merged 2 commits intodatabricks:masterfrom
srowen merged 2 commits intodatabricks:masterfrom
Conversation
srowen
commented
Jun 9, 2021
| nullable || | ||
| (options.treatEmptyValuesAsNulls && datum == "")){ | ||
| options: XmlOptions): Any = { | ||
| if ((datum == options.nullValue) || |
Collaborator
Author
There was a problem hiding this comment.
nullable was not used - always true. The code path here doesn't actually care about nullability of the column, which is ... OK ? if it returns null where it's not allowed, because the input said it was null, that's an error later anyway and probably correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #540
While the code did handle detection of input matching the
nullValueand returning null, in paths where the column type was a primitive in Java likeDoubleType, the cast turned it into 0.0. This adds additional checking to perform the same check earlier.