This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Fix type inference for Dates; code cleanup#521
Merged
srowen merged 4 commits intodatabricks:masterfrom Feb 19, 2021
Merged
Conversation
srowen
commented
Feb 18, 2021
| case v if isDouble(v) => DoubleType | ||
| case v if isBoolean(v) => BooleanType | ||
| case v if isTimestamp(v) => TimestampType | ||
| case v if isDate(v) => DateType |
Collaborator
Author
There was a problem hiding this comment.
This is really the fix; the rest is pretty much code cleanup
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 86.63% 86.85% +0.21%
==========================================
Files 18 18
Lines 928 928
Branches 81 79 -2
==========================================
+ Hits 804 806 +2
+ Misses 124 122 -2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is related to #519 but not its resolution)