Skip to content
This repository was archived by the owner on Mar 24, 2025. It is now read-only.

Use Text.toString to get Strings from XmlInputFormat#511

Merged
srowen merged 1 commit intodatabricks:masterfrom
srowen:Issue510
Dec 28, 2020
Merged

Use Text.toString to get Strings from XmlInputFormat#511
srowen merged 1 commit intodatabricks:masterfrom
srowen:Issue510

Conversation

@srowen
Copy link
Copy Markdown
Collaborator

@srowen srowen commented Dec 28, 2020

Closes #510
Use Text.toString to retrieve String from XmlInputFormat. This ensures that it isn't treated as UTF-8 when that isn't the configured encoding.

@srowen srowen added the bug label Dec 28, 2020
@srowen srowen added this to the 0.12.0 milestone Dec 28, 2020
@srowen srowen self-assigned this Dec 28, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 28, 2020

Codecov Report

Merging #511 (1da9f3d) into master (74b9802) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #511   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files          18       18           
  Lines         929      929           
  Branches       85       86    +1     
=======================================
  Hits          805      805           
  Misses        124      124           
Impacted Files Coverage Δ
.../scala/com/databricks/spark/xml/util/XmlFile.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b9802...1da9f3d. Read the comment docs.

@srowen srowen merged commit 5f7e37a into databricks:master Dec 28, 2020
@srowen srowen deleted the Issue510 branch December 28, 2020 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't Parse Encoding With Non Ascii Characters

2 participants