This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Don't silently swallow unclosed tag content; propagate for error handling instead#437
Merged
HyukjinKwon merged 1 commit intodatabricks:masterfrom Feb 14, 2020
Merged
Conversation
Collaborator
Author
|
CC @HyukjinKwon in case you're interested |
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
==========================================
+ Coverage 88.46% 88.86% +0.39%
==========================================
Files 17 17
Lines 806 808 +2
Branches 71 75 +4
==========================================
+ Hits 713 718 +5
+ Misses 93 90 -3
Continue to review full report at Codecov.
|
HyukjinKwon
approved these changes
Feb 14, 2020
Member
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM. Thanks @srowen for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #436 (comment) for context. This stops silently swallowing unclosed tags at the end of input and instead propagates the remaining content for normal error handling.
Closes #436