This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Allow multiple concurrent devbox instances#20
Merged
szeiger merged 1 commit intodatabricks:masterfrom Aug 19, 2020
Merged
Conversation
- They have to be started with different --url arguments. - The local git proxy is now bound to an automatically allocated port which gets mapped to 20280 on the devbox. - The tray icon tooltip shows the URL so you can identify the individual devbox instances.
iuliand-db
approved these changes
Aug 19, 2020
Contributor
iuliand-db
left a comment
There was a problem hiding this comment.
What happens if the --urls are not different?
| port: Int) | ||
| (implicit logger: FileLogger) { | ||
|
|
||
| // this may throw when binding if the socket is used, but for the moment we just assume there is no other |
Contributor
There was a problem hiding this comment.
I think this comment may no longer apply
Contributor
Author
There was a problem hiding this comment.
ReliableAgent has some logic to restart the server socket, in which case we still give it a non-0 port number because we need to bind to the same port which may have already been used for the tunnel.
Contributor
Author
|
If you use the same URL, it shuts down the old server and reuses the name, just as before. The mapping was already done by URL. It doesn't do anything about the running DevboxMain. It will eventually time out when the old server is gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They have to be started with different --url arguments.
The local git proxy is now bound to an automatically allocated port which gets mapped to 20280 on the devbox.
The tray icon tooltip shows the URL so you can identify the individual devbox instances.