Conversation
Member
Author
|
Close to done. Just need to test it out and then of course tackle publishing -- ideally in CI/CD |
Member
Author
|
Looks like theres decent support for CI/CD publishing on npm, so we can just get that setup and debugged and then maybe this almost good to do |
Member
Author
|
@donaldcampbelljr @khoroshevskyi still working on this I think... but its close |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 30.75% 30.23% -0.52%
==========================================
Files 66 67 +1
Lines 8370 8418 +48
==========================================
- Hits 2574 2545 -29
- Misses 5796 5873 +77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't complete. but the new workspace makes it a lot more amenable to create wasm bindings. To start, I had to add two new feature-flags to
gtars-core:bigbed(walls offbigtoolswhich wont compile to wasm), andhttp(walls offreqwestwhich also wouldn't compile to wasm)@khoroshevskyi these are both
RegionSetimplementation features so maybe we can discuss that a bit more. But it was actually quite easy to do.