Skip to content

feat: wait_tcp.py to python3#3701

Merged
bohutang merged 1 commit intodatabendlabs:mainfrom
yihong0618:main
Dec 30, 2021
Merged

feat: wait_tcp.py to python3#3701
bohutang merged 1 commit intodatabendlabs:mainfrom
yihong0618:main

Conversation

@yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Dec 30, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Changelog

  • Improvement
  • Build/Testing/CI
  • Not for changelog (changelog entry is not required)

Related Issues

As discussed in #3689 port the wait_tcp.py to Python3.
And use context manager to make sure the sock close.

@yihong0618 yihong0618 requested a review from bohutang as a code owner December 30, 2021 04:59
@databend-bot databend-bot added pr-build this PR changes build/testing/ci steps pr-improvement labels Dec 30, 2021
@databend-bot
Copy link
Member

databend-bot commented Dec 30, 2021

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot
Copy link
Member

databend-bot commented Dec 30, 2021

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Dec 30, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/2dqzHWz9EUcrJV65LHDCVcZPJL5R
✅ Preview: Canceled

flaneur2020
flaneur2020 reviewed Dec 30, 2021
View reviewed changes
scripts/deploy/databend-query-cluster-3-nodes.sh
--raft-api-port 28103 \
&
python scripts/ci/wait_tcp.py --timeout 5 --port 9191
python3 scripts/ci/wait_tcp.py --timeout 5 --port 9191
Copy link
Contributor

@flaneur2020 flaneur2020 Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the python3 command available in the major os environment like Darwin, ubuntu, fedora? q.q

Copy link
Contributor Author

@yihong0618 yihong0618 Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu and Darwin I think the answer yes

And I saw python3 command in dev_setup https://github.com/datafuselabs/databend/blob/main/scripts/setup/dev_setup.sh#L298

or maybe we can make the command from setup_dev too?

Copy link
Contributor

@flaneur2020 flaneur2020 Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, we can take the python commands the same among the script files

Copy link
Contributor Author

@yihong0618 yihong0618 Dec 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users env may have both python and python3 we can get the python env command in setup ln the python3 command.

@flaneur2020
Copy link
Contributor

flaneur2020 commented Dec 30, 2021

/lgtm

@yihong0618
Copy link
Contributor Author

yihong0618 commented Dec 30, 2021

@flaneur2020

and I noticed the bot comment same message many times seems based on the label count.
image

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021 •
edited
Loading

Codecov Report

Merging #3701 (dfbdb8d) into main (a2529db) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3701   +/-   ##
=====================================
- Coverage     60%     60%   -1%     
=====================================
  Files        706     706           
  Lines      37901   37901           
=====================================
- Hits       22806   22787   -19     
- Misses     15095   15114   +19
Impacted Files Coverage Δ
query/src/common/mod.rs 70% <0%> (-15%) ⬇️
common/containers/src/pool.rs 77% <0%> (-3%) ⬇️
common/dal/src/accessors/local.rs 85% <0%> (-2%) ⬇️
metasrv/src/meta_service/raftmeta.rs 47% <0%> (+<1%) ⬆️
...pelines/transforms/transform_aggregator_partial.rs 88% <0%> (+1%) ⬆️
query/src/storages/fuse/statistics/accumulator.rs 86% <0%> (+1%) ⬆️
common/management/src/cluster/cluster_mgr.rs 80% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2529db...dfbdb8d. Read the comment docs.

@bohutang
Copy link
Member

bohutang commented Dec 30, 2021

@yihong0618 Thank you!

@bohutang bohutang merged commit 7aff59a into databendlabs:main Dec 30, 2021
@yihong0618 yihong0618 mentioned this pull request Mar 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bohutang bohutang Awaiting requested review from bohutang

1 more reviewer

@flaneur2020 flaneur2020 flaneur2020 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-build this PR changes build/testing/ci steps

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yihong0618 @databend-bot @flaneur2020 @codecov-commenter @bohutang