Skip to content

[ci] Fix: perf maybe failed when run locally, issue #3689#3690

Merged
databend-bot merged 2 commits intodatabendlabs:mainfrom
yihong0618:main
Dec 29, 2021
Merged

[ci] Fix: perf maybe failed when run locally, issue #3689#3690
databend-bot merged 2 commits intodatabendlabs:mainfrom
yihong0618:main

Conversation

@yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Dec 29, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Changelog

  • Bug Fix
  • Build/Testing/CI
  • Documentation
  • Other
  • Not for changelog (changelog entry is not required)

Related Issues

#3689

Format some python code(delete unused code), and make code a bit pythonic
as use store_true instead of default "False"
image

@yihong0618 yihong0618 requested a review from bohutang as a code owner December 29, 2021 03:37
@databend-bot
Copy link
Member

databend-bot commented Dec 29, 2021

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added pr-bugfix this PR patches a bug in codebase pr-build this PR changes build/testing/ci steps pr-doc-fix labels Dec 29, 2021
@databend-bot
Copy link
Member

databend-bot commented Dec 29, 2021

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Dec 29, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/DBqrpWz98MmzZavKnY6kJo8aehM6
✅ Preview: Canceled

[Deployment for 003a859 canceled]

@bohutang bohutang requested a review from sundy-li December 29, 2021 03:45
@yihong0618 yihong0618 changed the title [ci]fix: perf maybe failed when run locally, issue #3689 [ci] Fix: perf maybe failed when run locally, issue #3689 Dec 29, 2021
@bohutang
Copy link
Member

bohutang commented Dec 29, 2021

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2021

update

✅ Branch has been successfully updated

Hey, I reacted but my real name is @Mergifyio

PsiACE
PsiACE approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021 •
edited
Loading

Codecov Report

Merging #3690 (003a859) into main (1b6bf39) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3690   +/-   ##
=====================================
  Coverage     60%     60%           
=====================================
  Files        697     697           
  Lines      37230   37230           
=====================================
+ Hits       22382   22392   +10     
+ Misses     14848   14838   -10
Impacted Files Coverage Δ
common/dal/src/context.rs 64% <0%> (-11%) ⬇️
common/management/src/cluster/cluster_mgr.rs 78% <0%> (-3%) ⬇️
common/streams/src/sources/source_parquet.rs 86% <0%> (-2%) ⬇️
metasrv/src/meta_service/raftmeta.rs 47% <0%> (-1%) ⬇️
common/datavalues/src/columns/data_column.rs 71% <0%> (+<1%) ⬆️
query/src/common/mod.rs 85% <0%> (+14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6bf39...003a859. Read the comment docs.

@databend-bot
Copy link
Member

databend-bot commented Dec 29, 2021

CI Passed
Reviewers Approved
Let's Merge
Thank you for the PR @yihong0618

@databend-bot databend-bot merged commit 0ef869a into databendlabs:main Dec 29, 2021
@PsiACE PsiACE mentioned this pull request Dec 29, 2021
Closed
@yihong0618 yihong0618 mentioned this pull request Mar 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sundy-li sundy-li sundy-li approved these changes

@bohutang bohutang Awaiting requested review from bohutang

+1 more reviewer

@PsiACE PsiACE PsiACE approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr-bugfix this PR patches a bug in codebase pr-build this PR changes build/testing/ci steps

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yihong0618 @databend-bot @bohutang @codecov-commenter @sundy-li @PsiACE