add dataset value attribute and provider attribute duplication use log#599
Merged
rmpestano merged 2 commits intodatabase-rider:masterfrom Jul 21, 2024
Conversation
Author
|
Could you please check it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, @rmpestano
Recently, I have been working on a project using database-rider, and I encountered a situation where I needed to use both the value and provider attributes of the @dataset annotation simultaneously. When I used them together, the execution completed without any logs, leading me to believe that everything was applied correctly. However, upon further inspection, I realized that neither attribute was actually applied.
I had to debug the internal logic step by step to discover that both attributes were not being applied. Some of my team members also went through the same trouble as I did.
Therefore, I believe that logging the following message when both the value and provider attributes of the @dataset annotation are used together would save others from experiencing the same issue. I am sending a PR with this change.
Have a great day.
before
after
