Skip to content

keeping table export ordering indicated in "includeTables"#581

Merged
rmpestano merged 1 commit intodatabase-rider:masterfrom
tomlux:master
Mar 18, 2024
Merged

keeping table export ordering indicated in "includeTables"#581
rmpestano merged 1 commit intodatabase-rider:masterfrom
tomlux:master

Conversation

@tomlux
Copy link
Copy Markdown
Contributor

@tomlux tomlux commented Mar 10, 2024 •
edited
Loading

The tables exported with ExportDataSet have no ordining.
These bothe ExportDataSet instructions are generateing the same export files:

  • @ExportDataSet(includeTables = {"PRODUCT","SUBPRODUCT"}, dependentTables = true)
  • @ExportDataSet(includeTables = {"SUBPRODUCT","PRODUCT"}, dependentTables = true)

Changing the code from HashMap to LinkedHashMap is givin the developer the control of the table ordering.

@rmpestano rmpestano added this to the 1.42.0 milestone Mar 17, 2024
@rmpestano
Copy link
Copy Markdown
Member

rmpestano commented Mar 17, 2024

Hi @tomlux,
There's one test failing, can you update it?

Error: Failures:
Error: ExportDataSetIt.assertGeneratedDataSets:388->assertDTDFileContentDependent:545

thanks for your contribution!

@rmpestano
Copy link
Copy Markdown
Member

rmpestano commented Mar 18, 2024

Seems it still has an ordering issue:


Error:  Failures: 
Error:    ExportDataSetCDIIt.assertGeneratedDataSets:219->assertDTDFileContentDependent:326 
Expecting:
 <"<!ELEMENT dataset (
    USER*,
    FOLLOWER*,
    TWEET*)>

<!ELEMENT USER EMPTY>
<!ATTLIST USER
    ID CDATA #REQUIRED
    NAME CDATA #IMPLIED
>

<!ELEMENT FOLLOWER EMPTY>
<!ATTLIST FOLLOWER
    ID CDATA #REQUIRED
    USER_ID CDATA #IMPLIED
    FOLLOWER_ID CDATA #IMPLIED
>

<!ELEMENT TWEET EMPTY>
<!ATTLIST TWEET
    ID CDATA #REQUIRED
    CONTENT CDATA #IMPLIED
    DATE CDATA #IMPLIED
    LIKES CDATA #IMPLIED
    USER_ID CDATA #IMPLIED
>

">
to contain:
 <"<!ELEMENT dataset (
    TWEET*,
    USER*,
    FOLLOWER*)>

<!ELEMENT TWEET EMPTY>
<!ATTLIST TWEET
    ID CDATA #REQUIRED
    CONTENT CDATA #IMPLIED
    DATE CDATA #IMPLIED
    LIKES CDATA #IMPLIED
    USER_ID CDATA #IMPLIED
>

<!ELEMENT USER EMPTY>
<!ATTLIST USER
    ID CDATA #REQUIRED
    NAME CDATA #IMPLIED
>

<!ELEMENT FOLLOWER EMPTY>
<!ATTLIST FOLLOWER
    ID CDATA #REQUIRED
    USER_ID CDATA #IMPLIED
    FOLLOWER_ID CDATA #IMPLIED
>

">

@rmpestano rmpestano merged commit f040829 into database-rider:master Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

1.42.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tomlux @rmpestano