Skip to content

Add generic type support to Future and Client methods#9123

Merged
jacobtomlinson merged 2 commits intodask:mainfrom
moi90:typing-client
Oct 15, 2025
Merged

Add generic type support to Future and Client methods#9123
jacobtomlinson merged 2 commits intodask:mainfrom
moi90:typing-client

Conversation

@moi90
Copy link
Copy Markdown
Contributor

@moi90 moi90 commented Oct 10, 2025 •
edited
Loading

Closes #9099

  • Tests added / passed
  • Passes pre-commit run --all-files

@moi90 moi90 requested a review from fjetter as a code owner October 10, 2025 10:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 10, 2025 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   9h 35m 56s ⏱️ - 7m 17s
 4 112 tests ±0   4 007 ✅ ±0    104 💤 ±0  1 ❌ ±0 
51 516 runs  ±0  49 331 ✅ +1  2 184 💤  - 1  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 81fe1e2. ± Comparison against base commit c9e7aca.

♻️ This comment has been updated with latest results.

jacobtomlinson
jacobtomlinson reviewed Oct 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jacobtomlinson jacobtomlinson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately mypy isn't happy with this. Could you take a look at the failing linter job and ensure mypy is passing. You might want to run pre-commit install to check this locally before pushing commits to GitHub.

@moi90
Copy link
Copy Markdown
Contributor Author

moi90 commented Oct 14, 2025

I now made sure the pre-commit hooks pass.

@jacobtomlinson
Copy link
Copy Markdown
Member

jacobtomlinson commented Oct 14, 2025

Docs build failures will be fixed by #9125

@moi90
Copy link
Copy Markdown
Contributor Author

moi90 commented Oct 14, 2025

Docs build failures will be fixed by #9125

Shall I then wait until #9125 is merged and then rebase?

@jacobtomlinson
Copy link
Copy Markdown
Member

jacobtomlinson commented Oct 14, 2025

You can if you like. It doesn't matter too much, I just wanted to point out that the docs build failure is unrelated to this PR.

@moi90 moi90 changed the title Add worker name as prefix to ThreadPoolExecutor name (#9120) Add generic type support to Future and Client methods Oct 14, 2025
@moi90
Copy link
Copy Markdown
Contributor Author

moi90 commented Oct 14, 2025

Ok. Apart from that: is there something left that I need to do before it can get merged?

jacobtomlinson
jacobtomlinson approved these changes Oct 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If mypy is happy then I'm happy 😆

@jacobtomlinson jacobtomlinson merged commit ac04bfa into dask:main Oct 15, 2025
28 of 33 checks passed
@moi90 moi90 deleted the typing-client branch October 15, 2025 07:13
@moi90
Copy link
Copy Markdown
Contributor Author

moi90 commented Oct 15, 2025

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typing for map, submit and Future

2 participants

@moi90 @jacobtomlinson