Skip to content

Warn for deprecations on dask.config.set()#8179

Merged
crusaderky merged 6 commits intodask:mainfrom
crusaderky:deprecations
Sep 14, 2023
Merged

Warn for deprecations on dask.config.set()#8179
crusaderky merged 6 commits intodask:mainfrom
crusaderky:deprecations

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

@crusaderky crusaderky commented Sep 11, 2023

dask.config.set on distributed-specific deprecated keys will now log a warning.

@crusaderky crusaderky requested review from jrbourbeau and removed request for fjetter September 11, 2023 15:43
@crusaderky
Copy link
Copy Markdown
Collaborator Author

@jrbourbeau ready for review (but blocked by dask PR)

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       21 files  ±  0         21 suites  ±0   10h 48m 47s ⏱️ + 22m 46s
  3 820 tests +  6    3 706 ✔️ +  2     107 💤 ±0    7 +  4 
36 927 runs  +72  35 067 ✔️ +18  1 799 💤  - 4  61 +58 

For more details on these failures, see this check.

Results for commit b90c049. ± Comparison against base commit e350c99.

Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crusaderky

@jrbourbeau jrbourbeau changed the title Warn for deprecations on dask.config.set() Warn for deprecations on dask.config.set() Sep 14, 2023
@jrbourbeau
Copy link
Copy Markdown
Member

Rerunning CI with caching off to make sure tests here pass

@crusaderky crusaderky merged commit b75f5da into dask:main Sep 14, 2023
@crusaderky crusaderky deleted the deprecations branch September 14, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants