Skip to content

Re-run erred task on ComputeTaskEvent#7967

Merged
crusaderky merged 2 commits intodask:mainfrom
hendrikmakait:rerun-erred-on-handle-compute
Jul 7, 2023
Merged

Re-run erred task on ComputeTaskEvent#7967
crusaderky merged 2 commits intodask:mainfrom
hendrikmakait:rerun-erred-on-handle-compute

Conversation

@hendrikmakait
Copy link
Copy Markdown
Member

@hendrikmakait hendrikmakait commented Jul 5, 2023

Addresses #7933 (comment)

I'm not sure if this condition can ever occur, but it still makes sense to harden the state machine against it and add a test.

  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait hendrikmakait requested a review from fjetter as a code owner July 5, 2023 12:05
@hendrikmakait hendrikmakait requested a review from crusaderky July 5, 2023 12:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 5, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  +       1         20 suites  +1   11h 41m 50s ⏱️ + 1h 12m 30s
  3 704 tests +       1    3 592 ✔️  -        3     106 💤 ±  0  6 +4 
35 826 runs  +1 348  34 071 ✔️ +1 262  1 748 💤 +81  7 +5 

For more details on these failures, see this check.

Results for commit 7d9c748. ± Comparison against base commit 67e073f.

@crusaderky
Copy link
Copy Markdown
Collaborator

I agree this use case should never happen.

@crusaderky crusaderky merged commit 631d92a into dask:main Jul 7, 2023
@hendrikmakait hendrikmakait deleted the rerun-erred-on-handle-compute branch July 7, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants