Skip to content

Add notes to Client docstrings with the description of the current task graph resolution algorithm limitations. #7588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fjetter merged 1 commit into from
Mar 6, 2023
Merged

Add notes to Client docstrings with the description of the current task graph resolution algorithm limitations. #7588

fjetter merged 1 commit into from
Mar 6, 2023

Conversation

@eugene-graft
Copy link
Contributor

@eugene-graft eugene-graft commented Feb 27, 2023 •
edited
Loading

This PR adds notes to Client docstrings with the description of the current task graph resolution algorithm limitations.

If I understand correctly the sphinx is configured to skip docstring notes in this repository. Should I address this issue in this PR to make the notes I added visible in the resulting documentation?

Closes #7551

  • Tests added / passed
  • Passes pre-commit run --all-files

@eugene-graft
Add notes to Client.submit, Client.map, and Client.scatter with…
2f27de7 
… the description of the current task graph resolution algorithm limitations.
@GPUtester
Copy link
Collaborator

GPUtester commented Feb 27, 2023

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@eugene-graft eugene-graft marked this pull request as ready for review February 27, 2023 18:38
@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       24 files  ±0         24 suites  ±0   11h 0m 20s ⏱️ - 9m 59s
  3 489 tests ±0    3 381 ✔️  - 1     104 💤 ±0    4 ❌ +1 
40 995 runs  ±0  39 111 ✔️ +1  1 850 💤  - 2  34 ❌ +1 

For more details on these failures, see this check.

Results for commit 2f27de7. ± Comparison against base commit f4328bb.

fjetter
fjetter approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and apologies for the delay of review!

@fjetter
Copy link
Member

fjetter commented Mar 6, 2023

And congratulations to your first contribution!

@fjetter
Copy link
Member

fjetter commented Mar 6, 2023

Test failures are unrelated and resolved on main

@fjetter fjetter merged commit 310fc95 into dask:main Mar 6, 2023
@eugene-graft eugene-graft deleted the docs/future-key-warning branch March 6, 2023 19:33
@eugene-graft
Copy link
Contributor Author

eugene-graft commented Mar 6, 2023

@fjetter thank you for your support and fast feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjetter fjetter fjetter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dask substitutes a string argument with a Future.result()

3 participants

@eugene-graft @GPUtester @fjetter