P2P: raise RuntimeError if pyarrow version is not sufficient#7578
Merged
P2P: raise RuntimeError if pyarrow version is not sufficient#7578
Conversation
3dfba7a to
e06101f
Compare
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 24 files ± 0 24 suites ±0 9h 55m 49s ⏱️ - 12m 46s For more details on these failures, see this check. Results for commit e06101f. ± Comparison against base commit 8f77b44. |
hendrikmakait
approved these changes
Feb 23, 2023
Member
There was a problem hiding this comment.
[EDIT: I overlooked the CI failures.]
Thanks @fjetter!
hendrikmakait
requested changes
Feb 23, 2023
Member
hendrikmakait
left a comment
There was a problem hiding this comment.
The check looks good to me, but CI needs fixing.
hendrikmakait
requested changes
Feb 23, 2023
Co-authored-by: Hendrik Makait <hendrik.makait@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is unfortunately never triggered on CI... we don't have a job that installs pandas but not pyarrow.