Skip to content

TST: Add missing skips for pyarrow#7416

Merged
mrocklin merged 1 commit intodask:mainfrom
QuLogic:skip-pyarrow
Dec 19, 2022
Merged

TST: Add missing skips for pyarrow#7416
mrocklin merged 1 commit intodask:mainfrom
QuLogic:skip-pyarrow

Conversation

@QuLogic
Copy link
Copy Markdown
Contributor

@QuLogic QuLogic commented Dec 18, 2022

As in test_split_by_partition in the same file.

  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       22 files  ±0         22 suites  ±0   10h 3m 23s ⏱️ + 3m 11s
  3 269 tests ±0    3 180 ✔️  - 2       85 💤 ±0  4 +2 
35 890 runs  ±0  34 367 ✔️  - 4  1 519 💤 +2  4 +2 

For more details on these failures, see this check.

Results for commit abfdbb0. ± Comparison against base commit 8c64fba.

@mrocklin
Copy link
Copy Markdown
Member

@hendrikmakait , this seems sensible to you? If so, I'll merge.

Copy link
Copy Markdown
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @QuLogic!

@mrocklin mrocklin merged commit ccede9c into dask:main Dec 19, 2022
Copy link
Copy Markdown
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QuLogic! We'll try to get #7285, which would have caught this, over the finish line

@QuLogic QuLogic deleted the skip-pyarrow branch December 19, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants