Skip to content

DRAFT: deprecate awaiting objects that need an async context manager#6836

Draft
graingert wants to merge 5 commits intodask:mainfrom
graingert:deprecate-awaiting-objects-that-need-a-context-manager
Draft

DRAFT: deprecate awaiting objects that need an async context manager#6836
graingert wants to merge 5 commits intodask:mainfrom
graingert:deprecate-awaiting-objects-that-need-a-context-manager

Conversation

@graingert
Copy link
Copy Markdown
Member

@graingert graingert commented Aug 5, 2022 •
edited
Loading

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

very drafty experiment just to see what breaks
see also:

await Client() can be done by doing something like:

def create_client(*, task_status):
    async with Client(...) as client:
        task_status.started(client)
        await sleep_forever()

async with create_task_group() as tg:
    client = await tg.start(create_client)

@graingert graingert force-pushed the deprecate-awaiting-objects-that-need-a-context-manager branch from b3c69fc to 1cd602b Compare August 5, 2022 12:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 5, 2022 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±  0         15 suites  ±0   6h 45m 42s ⏱️ + 22m 50s
  3 007 tests +  2    2 922 ✔️ ±0    84 💤 +  2  1 ❌ ±0 
22 255 runs  +16  21 273 ✔️ +2  981 💤 +14  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0a86d43. ± Comparison against base commit a1d2011.

♻️ This comment has been updated with latest results.

@hayesgb hayesgb added the asyncio label Aug 5, 2022
@graingert graingert force-pushed the deprecate-awaiting-objects-that-need-a-context-manager branch from 1cd602b to c402a48 Compare August 6, 2022 07:43
@graingert graingert mentioned this pull request Aug 8, 2022
Open
@graingert graingert force-pushed the deprecate-awaiting-objects-that-need-a-context-manager branch 3 times, most recently from d2a7d8a to 707dbd1 Compare August 12, 2022 12:06
@graingert graingert force-pushed the deprecate-awaiting-objects-that-need-a-context-manager branch 3 times, most recently from ad8605a to da75a75 Compare August 18, 2022 12:10
@graingert graingert force-pushed the deprecate-awaiting-objects-that-need-a-context-manager branch from b8b1f20 to 0a86d43 Compare August 19, 2022 09:35
@graingert graingert mentioned this pull request Aug 19, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjetter fjetter Awaiting requested review from fjetter fjetter will be requested when the pull request is marked ready for review fjetter is a code owner

Assignees

@graingert graingert

Labels

asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@graingert @hayesgb