Automatically mark all WorkerState tests#6706
Merged
crusaderky merged 1 commit intodask:mainfrom Jul 11, 2022
Merged
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 6h 34m 14s ⏱️ + 13m 52s For more details on these failures, see this check. Results for commit 97332b4. ± Comparison against base commit 6765e6e. |
hendrikmakait
approved these changes
Jul 11, 2022
Member
hendrikmakait
left a comment
There was a problem hiding this comment.
LGTM, great idea! I could foresee this flag getting blurry at some point in the future, but that's a problem to tackle at that point in time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically mark all tests that use the
wsor thews_with_running_taskfixtures.This allows running all and only such tests with
pytest -m workerstate.This in turn will allow, in the future,
WorkerState._transition_*using deterministic WorkerState tests only