Skip to content

Revisit WorkerState.long_running set#6697

Merged
crusaderky merged 5 commits intodask:mainfrom
crusaderky:long_running_set
Jul 8, 2022
Merged

Revisit WorkerState.long_running set#6697
crusaderky merged 5 commits intodask:mainfrom
crusaderky:long_running_set

Conversation

@crusaderky
Copy link
Copy Markdown
Collaborator

@crusaderky crusaderky commented Jul 8, 2022

@crusaderky crusaderky self-assigned this Jul 8, 2022
# for ts in self.long_running:
# assert ts.state == "long-running" or (
# ts.state in ("cancelled", "resumed") and ts._previous == "long-running"
# ), self.story(ts)
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as #6689 : there are tasks with "error" state in self.executing.

crusaderky and others added 2 commits July 8, 2022 15:19
Co-authored-by: Hendrik Makait <hendrik.makait@gmail.com>
Co-authored-by: Hendrik Makait <hendrik.makait@gmail.com>
@crusaderky crusaderky marked this pull request as ready for review July 8, 2022 14:20
@crusaderky crusaderky merged commit 1b34993 into dask:main Jul 8, 2022
@crusaderky crusaderky deleted the long_running_set branch July 8, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seceded tasks never leave WorkerState.long_running Seceded tasks don't release resources if they fail

2 participants