Remove unused __started Event in Server#6615
Conversation
|
I can't reproduce this issue using any tests, yet. maybe #5910 was already a fix. However, our old friend We can see that almost exactly 500ms from the start Is anybody aware of an interval we set to 500ms that could cause a scheduler to close? |
|
Another confusing part is that the CI run https://github.com/dask/distributed/runs/7021261881?check_suite_focus=true shows the following code for the test deftest_dashboard_port_zero(loop):
pytest.importorskip("bokeh")
port = open_port()
with popen(
[
"dask-scheduler",
"--host",
f"127.0.0.1:{port}",
"--dashboard-address",
":0",
],
):
> with Client(f"tcp://127.0.0.1:{port}", loop=loop) as c:which is the new version of this test after #6591 but my branch should still include the old version of the test, see https://github.com/fjetter/distributed/blob/eb679cc3912fa33cd6f24575973367ce99d71fcd/distributed/cli/tests/test_dask_scheduler.py#L217-L226 |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 10h 21m 30s ⏱️ - 37m 50s For more details on these failures, see this check. Results for commit d22cbbb. ± Comparison against base commit 4779f84. ♻️ This comment has been updated with latest results. |
eb679cc to
d22cbbb
Compare
|
well, I rebased and cherry-picked 9f9e1c2 onto it |
When a github action that contains - name: Checkout source
uses: actions/checkout@v2is triggered by a |
99b5220 to
a6aa916
Compare
I fixed this issue before for the worker, see #5910, but apparently the scheduler is now affected as well.From what I can gather this is related to many recent port collisions on CIsee also coiled/benchmarks#170I still need to figure out how to test this the best way. This is not a permanent fix but I think it should resolve the problem at hand.I consider #6616 as a permanent fixI believe no servers can be actually restarted this way after #5910. coiled/benchmarks#170 was running on 2022.1.0 which didn't include this fix. I was not able to reproduce this otherwise. I opted to remove the unused event instead.