Adding replicas to a task in fetch now sends it to flight immediately#6594
Merged
crusaderky merged 2 commits intodask:mainfrom Jun 27, 2022
Merged
Adding replicas to a task in fetch now sends it to flight immediately#6594crusaderky merged 2 commits intodask:mainfrom
crusaderky merged 2 commits intodask:mainfrom
Conversation
e919813 to
99b428f
Compare
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 10h 3m 9s ⏱️ - 10m 29s For more details on these failures, see this check. Results for commit 23b6d54. ± Comparison against base commit c82bba5. ♻️ This comment has been updated with latest results. |
2395a0e to
9558ac3
Compare
52986cc to
018705f
Compare
018705f to
23b6d54
Compare
fjetter
approved these changes
Jun 27, 2022
Member
fjetter
left a comment
There was a problem hiding this comment.
The style comment is mostly about how these tests should look like going on. I'm ok merging this now
Co-authored-by: Florian Jetter <fjetter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewriting the test was not strictly necessary - the old test is green once you merge #6497. I wanted to write a new WorkerState test to get a feel of how it looks like.