Merged
Conversation
6991040 to
8042a7a
Compare
Contributor
Unit Test Results 18 files ±0 18 suites ±0 8h 51m 53s ⏱️ - 12m 42s For more details on these failures, see this check. Results for commit 70ca320. ± Comparison against base commit 6e30766. ♻️ This comment has been updated with latest results. |
61554fe to
15982cc
Compare
graingert
commented
Apr 5, 2022
graingert
commented
Apr 5, 2022
Comment on lines
-1060
to
-1050
| async with await LocalCluster( | ||
| typo_kwarg="foo", |
Member
Author
There was a problem hiding this comment.
the asynchronous=True kwarg was missing so this spawned a new thread
6762202 to
26ce9bb
Compare
Member
Author
|
the macos failures seem unrelated |
sjperkins
reviewed
Apr 6, 2022
distributed/tests/test_preload.py
Outdated
| assert s.foo == 1 | ||
| assert "12345/preload" in log.getvalue() | ||
| with socket.create_server(("127.0.0.1", 0)) as server_sock: | ||
| await asyncio.gather(to_thread(preload), test()) |
Member
There was a problem hiding this comment.
This seems to be a more robust expression of the previous test, achieved by:
- Avoiding creating the preload application in a separate process
- Allowing a dynamically allocated port
Member
|
OSX 3.9 not ci1 failure #6076 |
fjetter
reviewed
Apr 6, 2022
gen_test doesn't transport marks correctly and so must be the first decorator applied to a test function also gen_test is stricter than pytest-asyncio it checks for leaky comms and threads, so we need to make sure resources are closed properly
f7da0a0 to
70ca320
Compare
Member
Author
|
test_client.py::test_reconnect timed out in py3.10 ci1 see also #6000 |
fjetter
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_test doesn't transport marks correctly and so must be the first
decorator applied to a test function
also gen_test is stricter than pytest-asyncio it checks for leaky comms and
threads, so we need to make sure resources are closed properly
pre-commit run --all-files