Closed
Conversation
Collaborator
|
Can one of the admins verify this patch? |
fjetter
reviewed
Mar 9, 2022
Member
fjetter
left a comment
There was a problem hiding this comment.
Thanks for opening this. I think this is very helpful to see examples of how this would look like.
I am still concerned about the ambiguity around duplicate module names like utils or core.
Comment on lines
+26
to
+27
| from ...utils import log_errors | ||
| from ..utils import update |
Member
There was a problem hiding this comment.
This is a nice example how things can become quite ambiguous
Collaborator
There was a problem hiding this comment.
Agreed, this is just the sort of thing I'd like to avoid having to read.
Contributor
Collaborator
|
should we just respect PEP8 and do everything absolute? I had not realised there were this many inconsistencies. |
Author
|
seems like there's a preference for absolute everywhere (🎉 ), so closing in favour of #5924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-files