Work around flakyness in spill hysteresis#5850
Closed
crusaderky wants to merge 12 commits intodask:mainfrom
Closed
Work around flakyness in spill hysteresis#5850crusaderky wants to merge 12 commits intodask:mainfrom
crusaderky wants to merge 12 commits intodask:mainfrom
Conversation
ca3e0b3 to
8f2ffa2
Compare
Contributor
This reverts commit ef0e44b.
Collaborator
Author
|
Stress test (120 runs) is all green: |
fjetter
reviewed
Feb 24, 2022
Member
fjetter
left a comment
There was a problem hiding this comment.
I would like to start a discussion about how we write tests for memory related things.
- This particular test is very complex and slow
- We're allocating a lot of memory. I would prefer keeping unit tests low on resources even if 1GB should be not a problem
- Relying on OS RSS reporting appears to be fragile. We're still xfailing on OSX.
I believe this is a situation where I would prefer mocking. The one measurement we rely on that is critical and the culprit for all the flakiness is proc.memory_info().rss. This is a very stable API and we could easily mock this by encapsulating it in a function. In the end, what we want to test is our spill logic assuming psutil/OS does properly report RSS. We do not want to test how the OS manages memory, this is outside of our control.
Collaborator
Author
|
Superseded by #5870 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_spill_hysteresisflaky on ubuntu #5848