Disable pytest-timeout SIGALARM on MacOS#5057
Merged
Conversation
b98ef18 to
f7bd6bb
Compare
f7bd6bb to
e553944
Compare
fjetter
approved these changes
Jul 15, 2021
Member
fjetter
left a comment
There was a problem hiding this comment.
Fine with all the changes. test_worker_heartbeat_after_cancel deadlocking might be a serious issue we should investigate (I'll try to reproduce locally)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5056
Disable hanging test test_worker_heartbeat_after_cancel
Disable ineffective signal-based pytest-timeout on MacOS