Skip to content

Add TaskState metadata#4191

Merged
jrbourbeau merged 2 commits intodask:masterfrom
jrbourbeau:task-metadata
Oct 28, 2020
Merged

Add TaskState metadata#4191
jrbourbeau merged 2 commits intodask:masterfrom
jrbourbeau:task-metadata

Conversation

@jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Oct 27, 2020

This PR adds a new .metadata attribute to the TaskState classes used by the scheduler and workers. When a task is finished the metadata stored on worker TaskStates synchronized with the corresponding TaskState on the scheduler

Closes #4188

@jrbourbeau jrbourbeau mentioned this pull request Oct 27, 2020
Closed
@mrocklin
Copy link
Member

mrocklin commented Oct 27, 2020

This seems pretty straightforward to me. +1

@mrocklin
Copy link
Member

mrocklin commented Oct 27, 2020

If you wanted to extend things very slightly it might also be interesting to add metadata to the task info pages if metadata is present

@jrbourbeau
Copy link
Member Author

jrbourbeau commented Oct 27, 2020

Good idea! Just pushed a commit which does that

Also, cc @quasiben as you expressed an interest in this over in #4188

@jrbourbeau
Copy link
Member Author

jrbourbeau commented Oct 28, 2020

Thanks for reviewing @mrocklin!

(for reference, test_broken_worker_during_computation is a known flaky test #4173)

@jrbourbeau jrbourbeau merged commit 24007c2 into dask:master Oct 28, 2020
@jrbourbeau jrbourbeau deleted the task-metadata branch October 28, 2020 21:45
@jrbourbeau jrbourbeau mentioned this pull request Nov 3, 2020
Merged
@quasiben quasiben mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TaskState metadata

2 participants

@jrbourbeau @mrocklin