Skip to content

Test Pandas Series is writeable#3995

Closed
jakirkham wants to merge 3 commits intodask:masterfrom
jakirkham:tst_pandas_series_writeable
Closed

Test Pandas Series is writeable#3995
jakirkham wants to merge 3 commits intodask:masterfrom
jakirkham:tst_pandas_series_writeable

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Jul 28, 2020

Follow-up to PR ( #3967 ) and issue ( #3943 )

Includes a test to ensure a Pandas Series is writeable after round-trip serialization.

@jakirkham jakirkham changed the title Test pandas Series is writeable Test Pandas Series is writeable Jul 28, 2020
This was referenced Jul 28, 2020
Merged
Closed
@quasiben
Copy link
Member

quasiben commented Jul 28, 2020

Looks like this is failing on the test submitted in the PR:
https://travis-ci.org/github/dask/distributed/jobs/712415247#L1560

@jakirkham
Copy link
Member Author

jakirkham commented Jul 28, 2020

Yeah I saw that last night. This is weird as it passed locally. Will look into it.

@mrocklin
Copy link
Member

mrocklin commented Jul 30, 2020

Checking in. Do we know what happened here? I ran into buffer source array is read-only errors on 2.21.0 recently and I'm curious if our latest release is broken.

@jakirkham
Copy link
Member Author

jakirkham commented Jul 30, 2020

The fix got merged after the last release unfortunately ( #3967 ). I suppose we could push out a patch release with that fix. Though we are planning to release tomorrow ( dask/community#77 )

A separate question is why this test doesn't work. Though people have already confirmed that PR does.

@mrocklin
Copy link
Member

mrocklin commented Jul 30, 2020

Ah ok, so we just need to release. Grand. Thanks @jakirkham !

@jakirkham jakirkham mentioned this pull request Jul 31, 2020
Merged
@jakirkham jakirkham deleted the tst_pandas_series_writeable branch August 4, 2020 00:38
@jakirkham
Copy link
Member Author

jakirkham commented Aug 4, 2020

This test was included as part of PR ( #4004 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakirkham @quasiben @mrocklin