Avoid diagnostics time in performance report#3654
Merged
jrbourbeau merged 1 commit intodask:masterfrom Mar 28, 2020
Merged
Conversation
Previously we would include all of the time taken to generate the performance report in the reported time. Now we record the time before we generate plots and use that instead.
jrbourbeau
approved these changes
Mar 28, 2020
Member
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks for the update @mrocklin!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would include all of the time taken to generate the
performance report in the reported time. Now we record the time before
we generate plots and use that instead.
This came from a comment in dask/dask-ml#619 (comment)