Skip to content

make work stealing callback time configurable#3523

Merged
TomAugspurger merged 1 commit intodask:masterfrom
lr4d:add_work_stealing_callback_config
Feb 27, 2020
Merged

make work stealing callback time configurable#3523
TomAugspurger merged 1 commit intodask:masterfrom
lr4d:add_work_stealing_callback_config

Conversation

@lr4d
Copy link
Copy Markdown
Contributor

@lr4d lr4d commented Feb 27, 2020

Makes it easier to benchmark #3069

Copy link
Copy Markdown
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a simple test for this, asserting that the change took effect?

with dask.config.set(...="500ms"):
    ws = WorkStealing(scheduler)

assert ws._pc.callback_time == 500

@lr4d lr4d force-pushed the add_work_stealing_callback_config branch from c151b79 to fb8bb6b Compare February 27, 2020 19:30
@TomAugspurger
Copy link
Copy Markdown
Member

Thanks!

@TomAugspurger TomAugspurger merged commit fc3e8d6 into dask:master Feb 27, 2020
@lr4d lr4d deleted the add_work_stealing_callback_config branch February 27, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants