Open
Conversation
This helps to normalize scheduler addresses before comparison Fixes dask#2336
Member
Author
Also, we add a scheduler_info attribute to Worker which matches that attribute on Client and Cluster
Member
Author
|
So previously we would pass the address along with serialized Futures for two reasons:
When we call Now we also pass along the scheduler ID string, and use that for verification instead. This makes us a bit more robust to bad addresses. |
Member
|
Just given this a test with this MRE. On this branch it hangs for me at |
Member
Author
|
@quasiben in case you're interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps to normalize scheduler addresses before comparison
Fixes #2336
I'm working on a test now, but I thought I'd push this up in the meantime.