Pytest 4 support for tests#2478
Conversation
|
In general this looks good to me. CI is showing two failures. One seems to be unrelated and probably due to a conda issue (will likely fix itself when we next run CI) The other appears to be a flake8 issue (you can see this by clicking "Details" next to the travis-ci line above and then looking at the last line that says |
|
You can also verify flake8 locally by running Much like how you would run py.test |
|
Python 3.5 is unhappy with pytest 4.1.1, looks like pytest 3.8.1 is the last one to have a satisfiable |
|
Short term I recommend that we just unpin pytest and let the solver figure it out. |
|
This looks good to me. Merging. Thanks @beberg ! Also, I notice that this is your first code contribution to this repository. Welcome! |
Fixes #2476