Skip to content

Pytest 4 support for tests#2478

Merged
mrocklin merged 7 commits intodask:masterfrom
beberg:pytest4
Jan 24, 2019
Merged

Pytest 4 support for tests#2478
mrocklin merged 7 commits intodask:masterfrom
beberg:pytest4

Conversation

@beberg
Copy link
Contributor

@beberg beberg commented Jan 23, 2019

Fixes #2476

@mrocklin
Copy link
Member

In general this looks good to me. CI is showing two failures. One seems to be unrelated and probably due to a conda issue (will likely fix itself when we next run CI)

The other appears to be a flake8 issue

distributed/tests/test_resources.py:283:5: E123 closing bracket does not match indentation of opening bracket's line

(you can see this by clicking "Details" next to the travis-ci line above and then looking at the last line that says LINT=true)

@mrocklin
Copy link
Member

You can also verify flake8 locally by running

$ flake8 distributed

Much like how you would run py.test

$ py.test distributed

@beberg
Copy link
Contributor Author

beberg commented Jan 24, 2019

Python 3.5 is unhappy with pytest 4.1.1, looks like pytest 3.8.1 is the last one to have a satisfiable python >=3.5,<3.6.0a0.

@mrocklin
Copy link
Member

Short term I recommend that we just unpin pytest and let the solver figure it out.

@mrocklin mrocklin merged commit f434cc4 into dask:master Jan 24, 2019
@mrocklin
Copy link
Member

This looks good to me. Merging. Thanks @beberg !

Also, I notice that this is your first code contribution to this repository. Welcome!

@beberg beberg deleted the pytest4 branch January 24, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants