Make it more explict that resources are per worker.#2470
Merged
mrocklin merged 4 commits intodask:masterfrom Jan 28, 2019
Merged
Make it more explict that resources are per worker.#2470mrocklin merged 4 commits intodask:masterfrom
mrocklin merged 4 commits intodask:masterfrom
Conversation
Add example for how to execute non thread-safe tasks.
mrocklin
reviewed
Jan 21, 2019
Member
guillaumeeb
reviewed
Jan 21, 2019
Member
guillaumeeb
left a comment
There was a problem hiding this comment.
I think that we should also modify the dask-worker command help: https://github.com/dask/distributed/blob/master/distributed/cli/dask_worker.py#L85
Make it more like https://github.com/dask/distributed/blob/master/distributed/cli/dask_worker.py#L71
Member
Author
|
I tackled all the comments I think. Let me know if something can be improved! |
Member
Author
|
I am only changing documentation so I bet the Travis error is not related to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although it is mentioned in the text already, I was confused between the
dask-workercommand (that can create multiple workers) vs "worker".I think that adding a simple example with
dask-worker --nprocshelps clearing the suggestion. Suggestions on how to improve it more than welcome!For more context, some (long) discussion happened in dask/dask-jobqueue#181 about how to execute tasks that managed threading internally (in the OP python bindings on top of C++ code that does multi-threading) and some concerns about running non thread-safe tasks in combination with resources. I have to say it took me a while to figure out that resources could be used to solve the problem.