Add timeout to ThreadPoolExecutor.shutdown#1330
Merged
mrocklin merged 3 commits intodask:masterfrom Aug 14, 2017
Merged
Conversation
Member
|
I am surprised it would reduce memory leaks. Have you found out why? |
Member
Author
No. This surprised me as well. Something was keeping the state of the thread in memory. |
6311c0d to
dcac104
Compare
dcac104 to
f340e06
Compare
Member
Author
|
I plan to merge this soon if there are no further comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This significantly reduces memory leaks during testing