-
-
Notifications
You must be signed in to change notification settings - Fork 756
Open
Labels
enhancementImprove existing functionality or make things work betterImprove existing functionality or make things work betterhygieneImprove code quality and reduce maintenance overheadImprove code quality and reduce maintenance overhead
Description
With #6361, any temporary network disconnect will shut down the worker.
If we have a Nanny around, we could at least let the Nanny restart the worker, so it can try to reconnect from a fresh state. Currently, we tell the Nanny to close gracefully.
There are a couple of things to think about:
- Make sure that, if the scheduler has asked us to close and then closes the connection, the Nanny doesn't try to restart
- The Nanny also reports worker loss to the scheduler. This shouldn't happen until the worker process is already closed, which means the network connection should already be closed, so the scheduler should have already removed the worker itself, but think about race conditions here.
- Consider connection-failure worker closures as safe? #6386
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementImprove existing functionality or make things work betterImprove existing functionality or make things work betterhygieneImprove code quality and reduce maintenance overheadImprove code quality and reduce maintenance overhead