Skip to content

[test coverage] decide_workers never returns None in the unit tests #6254

New issue
New issue
Open
Open
[test coverage] decide_workers never returns None in the unit tests#6254
Labels
testsUnit tests and/or continuous integration
@crusaderky

Description

@crusaderky
crusaderky
opened on May 1, 2022

distributed/distributed/scheduler.py

Lines 1951 to 1956 in 223c815

if self.validate:
assert ws is None or isinstance(ws, WorkerState), (
type(ws),
ws,
)
assert ws.address in self.workers

This bug makes everything crash with AttributeError whenever the top-level function decide_workers returns None.
However, no unit test (where validate=True) catches this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsUnit tests and/or continuous integration

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions