Skip to content

Commit a10d2b7

Browse files
authored
Apply suggestions from code review
1 parent b46814a commit a10d2b7

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

distributed/tests/test_utils_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ async def f(s, a, b):
284284

285285

286286
def test_lingering_client_2(loop):
287-
# assert where the client went
287+
# TODO: assert where the client went
288288
with cluster() as (s, [a, b]):
289289
client = Client(s["address"], loop=loop)
290290

distributed/tests/test_worker.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1019,9 +1019,10 @@ def f(x):
10191019
@gen_cluster(client=True)
10201020
async def test_get_client_coroutine(c, s, a, b):
10211021
async def f():
1022-
# TODO: `await get_client()` raises a deprecation warning to use
1023-
# `async with get_client()` and that will kill the workers' client
1022+
# TODO: the existence of `await get_client()` implies the possibility
1023+
# of `async with get_client()` and that will kill the workers' client
10241024
# if you do that. We really don't want users to do that.
1025+
# https://github.com/dask/distributed/pull/6921/
10251026
client = get_client()
10261027
future = client.submit(inc, 10)
10271028
result = await future

0 commit comments

Comments
 (0)