make regression metrics 'multioutput' behavior consistent with scikit-learn (fixes #818)#820
Merged
TomAugspurger merged 3 commits intodask:mainfrom Apr 10, 2021
jameslamb:fix/series-metrics
Merged
make regression metrics 'multioutput' behavior consistent with scikit-learn (fixes #818)#820TomAugspurger merged 3 commits intodask:mainfrom jameslamb:fix/series-metrics
TomAugspurger merged 3 commits intodask:mainfrom
jameslamb:fix/series-metrics
Conversation
TomAugspurger
approved these changes
Apr 10, 2021
Member
TomAugspurger
left a comment
There was a problem hiding this comment.
Agreed that the old behavior was incorrect. Thanks for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #818.
Fixes #819.
Changes in this PR
computeargument whenmultioutput == "raw_values"multioutput=Nonematches the behavior of their scikit-learn equivalentsnp.average()in regression metricsmultioutputBackground
See the linked issues for an explanation. I believe this PR is worth accepting because it will resolve an inconsistency with
scikit-learnand withdask-mlitself, but it is technically a breaking change.Thanks for your time and consideration.