MAINT: Add type hints to model selection#668
Merged
TomAugspurger merged 8 commits intodask:masterfrom Jul 14, 2020
Merged
Conversation
Member
Author
|
It also checks the type hints via assert statements so I could test easily. I plan on ripping these assert statements out before merge (but it's useful for me to test). I looked at adding some dynamic type checking but typeguard significantly slowed down the tests. |
Member
Author
|
I think this PR is ready for merge. There are no asserts or modifications to the tests. |
Member
|
Looks good, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement?
It adds type hints in the
model_selection/_incremental.pyand_hyperband.py.Reference issues/PR
This resolves #607