Draft
Conversation
This reverts commit 58180d2.
This reverts commit 8bf3046.
…ask-ml into model-selection-docs
* Also reorganize initial section to make it more clear
Make more unstable and test for longer
DOC: add outline yield -> await decay_rate=1? One search? tol? eta0? random_state? Simpler parameters? Remove clone? Change name? Add large n_initial? smaller max_iter? Run in notebook Small reorg to rst Remove clone whoops decay_rate? test_numpy: make alpha <= 1e-3 != 1e10 decay_rate=0? Add outline
Co-Authored-By: Dave Hirschfeld <dave.hirschfeld@gmail.com>
Co-Authored-By: Tom Augspurger <TomAugspurger@users.noreply.github.com>
b6dd892 to
02a905a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement?
It cleans up the implementation of
InverseDecaySearchCVby makingInverseDecaySearchCVrespectmax_iter. The modified adaptive algorithm considersn_initial_parametersmodels initially and 2 models atmax_iterpartial fit calls.Reference issues/PRs
This PR depends on #432. The diff will be reduced significantly after that PR gets merged.
TODO:
InverseDecaySearchCV.from(cls: SuccessiveHalvingSearchCV), and associated cleanups.