Skip to content

Added annotations to preprocessing#640

Merged
TomAugspurger merged 14 commits intodask:masterfrom
prasunanand:annotate_preprocessing
May 5, 2020
Merged

Added annotations to preprocessing#640
TomAugspurger merged 14 commits intodask:masterfrom
prasunanand:annotate_preprocessing

Conversation

@prasunanand
Copy link
Copy Markdown
Contributor

@prasunanand prasunanand commented Apr 12, 2020

  • Added annotations
  • Needed to add --no-strict-optional because of this issue

@prasunanand prasunanand marked this pull request as ready for review April 16, 2020 14:29
Copy link
Copy Markdown
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you add return types where possible?

@prasunanand
Copy link
Copy Markdown
Contributor Author

@TomAugspurger Please take a look at this. I think its good to go.

@TomAugspurger TomAugspurger merged commit fbcfdf7 into dask:master May 5, 2020
@TomAugspurger
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants