DOC: mirrors cv note in Scikit-Learn docs for RandomizedSearchCV#506
Merged
TomAugspurger merged 7 commits intodask:masterfrom May 27, 2020
Merged
DOC: mirrors cv note in Scikit-Learn docs for RandomizedSearchCV#506TomAugspurger merged 7 commits intodask:masterfrom
TomAugspurger merged 7 commits intodask:masterfrom
Conversation
Member
Author
|
I think this PR should verify that the Scikit-Learn documentation doesn't have other wording changes. |
Member
What do you mean by this? |
Member
Author
I’d like to check that the Dask-searchcv docs match the sklearn docs |
Member
Author
|
Now most of Dask's RandomizedSearchCV mirrors Scikit-learn's RandomizedSearchCV; this PR should be ready for merge now (almost all the changes are documentation changes). Most of the doc additions were not relevant to the tests; I've added a small test case for the one relevant test. |
TomAugspurger
approved these changes
May 27, 2020
Member
TomAugspurger
left a comment
There was a problem hiding this comment.
Merged master to fix CI. Ping on green.
…/dask-ml into doc-model-selection-cv
Member
Author
|
All green! |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement?
This is a quick and dirty fix to mirror Scikit-Learn's documentation better.
This resolves an issue I ran into that took about 15 minutes to resolve.