Fix incremental bug with Dask sharedict#455
Merged
TomAugspurger merged 1 commit intodask:masterfrom Feb 13, 2019
Merged
Conversation
TomAugspurger
approved these changes
Feb 13, 2019
Member
TomAugspurger
left a comment
There was a problem hiding this comment.
LGTM.
#456 for actually testing this on CI.
Member
Author
|
@TomAugspurger by supporting |
Member
Author
|
You beat me to it! |
Member
|
Thanks. #457 for the doc issue. |
This was referenced Feb 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we're passing a dictionary
valuesmethod tosharedict.mergeinstead of the actual values themselves. Fixes #454.